Fix NDE caused by removing Workflow.getVersion with a succeeding Work… #2370
Conversation
There was a problem hiding this comment.
I kinda understand this, but I won't pretend to deeply understand it (I don't understand very deeply why Java chose to do fake commands for matching), but given the fact that nobody but you might be able to understand it without significant effort, I'm approving.
| @@ -525,6 +525,24 @@ private void handleCommandEvent(HistoryEvent event) { | |||
| continue; | |||
| } | |||
|
|
|||
| if (VersionMarkerUtils.hasVersionMarkerStructure(event) | |||
| && !VersionMarkerUtils.hasVersionMarkerStructure(command.getCommand())) { | |||
There was a problem hiding this comment.
I think I understand what's happening here. So is !VersionMarkerUtils.hasVersionMarkerStructure(command.getCommand()) basically saying isFakeVersionMarker?
There was a problem hiding this comment.
Yeah this code deserves a comment. I will add it. !VersionMarkerUtils.hasVersionMarkerStructure(command.getCommand()) is basically checking if the command is from a Workflow.getVersion call. What I am checking here is, if the history event is a version marker, but the command isn't that means this event can't match with the command so it must be a removed version marker
Quinn-With-Two-Ns
force-pushed
the
issue-2367
branch
from
4e30282 to
818cecf
Compare
closes #2367